Handle slack rate limit for does_user_exist #4597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update `does_user_exist` in slack/service.py to use the `get_user_info_by_email` and `make_call` functions. If the USER_NOT_FOUND error occurs from `make_call` it is expected to be raised again and handled in `does_user_exist`
whitdog47
approved these changes
Apr 8, 2024
whitdog47
reviewed
Apr 8, 2024
return data to the ether Co-authored-by: David Whittaker <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update
does_user_existin slack/service.py to use theget_user_info_by_emailandmake_callfunctions. If the USER_NOT_FOUND error occurs frommake_callit is expected to be raised again and handled indoes_user_exist