[Bugs] Check incident status before re-adding IC #4582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whitdog47
approved these changes
Apr 3, 2024
jschroth
force-pushed
the
bug/no_ic_readd_after_close
branch
from
c96fdb1 to
0873bfc
Compare
If an incident is closed, we expect the incident conversation to be closed as well. This will cause errors in slack, if we try to add someone to an archived conversation and send a message to that archived conversation.
jschroth
force-pushed
the
bug/no_ic_readd_after_close
branch
from
0873bfc to
777ca0f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an incident is closed, we expect the incident conversation to be closed as well. This will cause errors in slack, if we try to add someone to an archived conversation and send a message to that archived conversation.