Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds 250/minute rate limit to SignalInstance POST API endpoint using slowapi #3338

Merged
merged 4 commits into from
May 5, 2023
Merged

Adds 250/minute rate limit to SignalInstance POST API endpoint using slowapi #3338

merged 4 commits into from
May 5, 2023

Conversation

wssheldon
Copy link
Contributor

No description provided.

@wssheldon wssheldon added the enhancement New feature or request label May 2, 2023
@wssheldon wssheldon requested a review from mvilanova May 2, 2023 17:42
mvilanova
mvilanova approved these changes May 2, 2023
View reviewed changes
src/dispatch/signal/views.py Show resolved Hide resolved
@wssheldon
Copy link
Contributor Author 

DEBUG:http://localhost:8080 "POST /api/v1/default/signals/instances HTTP/1.1" 429 28:/Users/wshel/.pyenv/versions/3.11.2/envs/dispatch-prod/lib/python3.11/site-packages/urllib3/connectionpool.py:_make_request:456
INFO:Response: {'detail': '10 per 1 minute'}:/Users/wshel/Projects/dispatch/src/dispatch/cli.py:_send_signal_instance:749
ERROR:Unable to send finding. Reason: 429 Client Error: Too Many Requests for url: http://localhost:8080/api/v1/default/signals/instances Response: N/A:/Users/wshel/Projects/dispatch/src/dispatch/cli.py:_send_signal_instance:758

@wssheldon wssheldon merged commit 39f1211 into master May 5, 2023
@wssheldon wssheldon deleted the enhancement/instance-ratelimit branch May 5, 2023 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvilanova mvilanova mvilanova approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wssheldon @mvilanova