Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add footer and pagination to summary tables to fix global search #3247

Merged
merged 1 commit into from
Apr 10, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions src/dispatch/plugins/dispatch_slack/incident/interactive.py
Original file line number Diff line number Diff line change
Expand Up @@ -155,12 +155,6 @@ def configure(config):
command_context_middleware,
]

middleware = [
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was duplicate code

subject_middleware,
configuration_middleware,
command_context_middleware,
]

app.command(config.slack_command_list_tasks, middleware=middleware)(handle_list_tasks_command)
app.command(config.slack_command_list_my_tasks, middleware=middleware)(
handle_list_tasks_command
Expand Down
1 change: 0 additions & 1 deletion src/dispatch/signal/flows.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
from dispatch.case import service as case_service
from dispatch.case.models import CaseCreate
from dispatch.database.core import SessionLocal
from dispatch.decorators import background_task
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not used anymore

from dispatch.entity import service as entity_service
from dispatch.project.models import Project
from dispatch.signal import service as signal_service
Expand Down
9 changes: 1 addition & 8 deletions src/dispatch/static/dispatch/src/case/CaseSummaryTable.vue
Original file line number Diff line number Diff line change
@@ -1,13 +1,6 @@
<template>
<div>
<v-data-table
:headers="headers"
:items="items"
:loading="loading"
:items-per-page="-1"
disabled-pagination
hide-default-footer
>
<v-data-table :headers="headers" :items="items" :loading="loading" :items-per-page="-1">
<template v-slot:item.case_priority.name="{ item }">
<case-priority :priority="item.case_priority.name" />
</template>
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<template>
<div>
<v-data-table :headers="headers" :items="items" hide-default-footer>
<v-data-table :headers="headers" :items="items">
<template v-slot:item.project.name="{ item }">
<v-chip small :color="item.project.color" text-color="white">
{{ item.project.name }}
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<template>
<div>
<v-data-table :headers="headers" :items="items" hide-default-footer>
<v-data-table :headers="headers" :items="items">
<template v-slot:item.name="{ item }">
<router-link
:to="{
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<template>
<div>
<v-data-table :headers="headers" :items="items" hide-default-footer>
<v-data-table :headers="headers" :items="items">
<template v-slot:item.name="{ item }">
<a :href="item.weblink" target="_blank" style="text-decoration: none">
{{ item.name }}
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<template>
<div>
<v-data-table :headers="headers" :items="items" :loading="loading" hide-default-footer>
<v-data-table :headers="headers" :items="items" :loading="loading">
<template v-slot:item.incident_priority.name="{ item }">
<incident-priority :priority="item.incident_priority.name" />
</template>
Expand Down
2 changes: 1 addition & 1 deletion src/dispatch/static/dispatch/src/tag/TagSummaryTable.vue
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<template>
<div>
<new-edit-sheet />
<v-data-table :headers="headers" :items="items" hide-default-footer>
<v-data-table :headers="headers" :items="items">
<template v-slot:item.discoverable="{ item }">
<v-simple-checkbox v-model="item.discoverable" disabled />
</template>
Expand Down
2 changes: 1 addition & 1 deletion src/dispatch/static/dispatch/src/task/TaskSummaryTable.vue
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<template>
<div>
<new-edit-sheet />
<v-data-table :headers="headers" :items="items" :loading="loading" hide-default-footer>
<v-data-table :headers="headers" :items="items" :loading="loading">
<template v-slot:item.description="{ item }">
<div class="text-truncate" style="max-width: 400px">
{{ item.description }}
Expand Down