Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confluence storage and document plugin #2940

Merged
merged 5 commits into from
Feb 7, 2023
Merged

Confluence storage and document plugin #2940

merged 5 commits into from
Feb 7, 2023

Conversation

Cinojose
Copy link
Contributor

@Cinojose Cinojose commented Feb 3, 2023

An attempt to create a confluence plugin for both storage and document.

The plugin right now supports only cloud hosted confluence and can be extended down the road. Logs and sheets are not supported as confluence has no such concept. it make use of the atlassian-python-api for the confluence api calls.

I can create some screenshots on how it looks like, if there is a need. Please review.

@Cinojose Cinojose marked this pull request as ready for review February 4, 2023 04:39
Copy link
Contributor

@mvilanova mvilanova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far. Just minor stuff. I think there's an opportunity to have all the atlassian-related plugins (Jira and Confluence) under the same directory now and have all of them leverage (and extend if necessary) the config stuff such as HostingType and API related things. We could tackle it in a separate PR.

setup.py Outdated Show resolved Hide resolved
src/dispatch/incident/flows.py Show resolved Hide resolved
src/dispatch/plugins/dispatch_confluence/config.py Outdated Show resolved Hide resolved
src/dispatch/plugins/dispatch_confluence/config.py Outdated Show resolved Hide resolved
src/dispatch/plugins/dispatch_confluence/plugin.py Outdated Show resolved Hide resolved
src/dispatch/plugins/dispatch_confluence/plugin.py Outdated Show resolved Hide resolved
src/dispatch/plugins/dispatch_confluence/plugin.py Outdated Show resolved Hide resolved
src/dispatch/plugins/dispatch_confluence/plugin.py Outdated Show resolved Hide resolved
src/dispatch/plugins/dispatch_confluence/plugin.py Outdated Show resolved Hide resolved
src/dispatch/plugins/dispatch_confluence/plugin.py Outdated Show resolved Hide resolved
@mvilanova mvilanova added the enhancement New feature or request label Feb 6, 2023
@mvilanova
Copy link
Contributor

Thanks for the PR!

@mvilanova mvilanova merged commit ead6707 into Netflix:master Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants