Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a subscribe button to incident notifications #1793

Merged
merged 1 commit into from
Nov 8, 2021

Conversation

kevgliss
Copy link
Contributor

@kevgliss kevgliss commented Nov 8, 2021

No description provided.

@kevgliss kevgliss added the enhancement New feature or request label Nov 8, 2021
@kevgliss kevgliss merged commit 9ef6592 into master Nov 8, 2021
@kevgliss kevgliss deleted the enhancement/subscribe-button branch November 8, 2021 21:16
@lgtm-com
Copy link

lgtm-com bot commented Nov 8, 2021

This pull request introduces 1 alert when merging 7bad8bd into 18279fd - view on LGTM.com

new alerts:

  • 1 for Unused import

@vikassinha2019
Copy link

@kevgliss can you please provide a screenshot where this Subscribe button will show up.
Also will it work for newly created incidents after upgrading Dispatch to v20211116, or will it work on open incidents from old version as well ?

@kevgliss
Copy link
Contributor Author

kevgliss commented Dec 3, 2021

@vikassinha2019 this button will only show up for new messages (created after that push is deployed). It should look something like:
Screen Shot 2021-12-03 at 9 40 48 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants