Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HttpClientResponse and HttpServerRequest should accept rx Subject instead of PublishSubject #158

Closed
NiteshKant opened this issue Jun 30, 2014 · 0 comments
Closed

HttpClientResponse and HttpServerRequest should accept rx Subject instead of PublishSubject #158

NiteshKant opened this issue Jun 30, 2014 · 0 comments
Milestone
0.3.7

Comments

@NiteshKant
Copy link
Member

For the enclosing content HttpClientResponse and HttpServerRequest accepts a PublishSubject. This restricts the usage of these classes. It should instead accept Subject
@NiteshKant NiteshKant added this to the 0.3.7 milestone Jun 30, 2014
@NiteshKant NiteshKant self-assigned this Jun 30, 2014
NiteshKant pushed a commit to NiteshKant/RxNetty that referenced this issue Jun 30, 2014
Fixes issue ReactiveX#158
f590cf4 
Accept Subject instead of PublishSubject
@NiteshKant NiteshKant mentioned this issue Jun 30, 2014
Merged
NiteshKant added a commit that referenced this issue Jun 30, 2014
@NiteshKant
Merge pull request #157 from NiteshKant/master
ec06907 
Fixes issue #155 #156 #158
@NiteshKant NiteshKant removed their assignment Aug 19, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.3.7
Development

No branches or pull requests
1 participant
@NiteshKant