Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Iss 948 #977

Merged
merged 12 commits into from
Nov 24, 2015
Merged

Iss 948 #977

merged 12 commits into from
Nov 24, 2015

Conversation

dmgcodevil
Copy link
Contributor

No description provided.

@cloudbees-pull-request-builder
Copy link

NetflixOSS » Hystrix » Hystrix-pull-requests #248 SUCCESS
This pull request looks good

@spencergibb
Copy link
Contributor

I look forward to reviewing this Monday!

@cloudbees-pull-request-builder
Copy link

NetflixOSS » Hystrix » Hystrix-pull-requests #249 SUCCESS
This pull request looks good

@dmgcodevil
Copy link
Contributor Author

@spencergibb thanks in advance, I haven't finish it yet, but you can take a look at the test for observable, because PL is very big. BTW I didn't implement collapser feature for observable command, but hopefully will add it soon.

@cloudbees-pull-request-builder
Copy link

NetflixOSS » Hystrix » Hystrix-pull-requests #250 SUCCESS
This pull request looks good

@cloudbees-pull-request-builder
Copy link

NetflixOSS » Hystrix » Hystrix-pull-requests #251 SUCCESS
This pull request looks good

@cloudbees-pull-request-builder
Copy link

NetflixOSS » Hystrix » Hystrix-pull-requests #252 SUCCESS
This pull request looks good

@dmgcodevil dmgcodevil mentioned this pull request Nov 19, 2015
Closed
@mattrjacobs
Copy link
Contributor

@dmgcodevil Is this ready for review and merge? If so, I'll take a look this weekend

@dmgcodevil
Copy link
Contributor Author

@mattrjacobs yes, it's pretty much done except Collapser for observable but it will change within separate issue

@spencergibb
Copy link
Contributor

@dmgcodevil 👍

mattrjacobs added a commit that referenced this pull request Nov 24, 2015
@mattrjacobs
Merge pull request #977 from dmgcodevil/iss-948
3509b8f 
Iss 948
@mattrjacobs mattrjacobs merged commit 3509b8f into Netflix:master Nov 24, 2015
@mattrjacobs
Copy link
Contributor

LGTM. Thanks for all your work on this

dmgcodevil
dmgcodevil reviewed Apr 12, 2016
View reviewed changes
...ix-javanica/src/main/java/com/netflix/hystrix/contrib/javanica/command/ObservableResult.java
@@ -1,46 +0,0 @@
/**
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove ObservableResult #948

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dmgcodevil @cloudbees-pull-request-builder @spencergibb @mattrjacobs