Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HystrixMetricsStreamServlet rejects requests after servlet shutdown (fixes #786) #787

Conversation

lasselasse
Copy link
Contributor

Reject requests with a 503 status code when the servlet has been shutdown. This prevents a new HystrixMetricsPoller to be started, defeating the original reason shutdown has been added (cf. #346).

@lasselasse lasselasse changed the title Reject requests after servlet shutdown (fixes #786) HystrixMetricsStreamServlet rejects requests after servlet shutdown (fixes #786) May 5, 2015
@cloudbees-pull-request-builder

NetflixOSS » Hystrix » Hystrix-pull-requests #118 SUCCESS
This pull request looks good

@cloudbees-pull-request-builder

NetflixOSS » Hystrix » Hystrix-pull-requests #119 SUCCESS
This pull request looks good

@mattrjacobs
Copy link
Contributor

Thanks for this change, @lasselasse

mattrjacobs added a commit that referenced this pull request May 5, 2015
…when-destroyed

HystrixMetricsStreamServlet rejects requests after servlet shutdown (fixes #786)
@mattrjacobs mattrjacobs merged commit 9002320 into Netflix:master May 5, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants