-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check if the request log is enabled before requiring the context is initialized. #724
Conversation
…nitialized. In Netflix@706a0f2, the guard to initialize the request log based on the property was removed. This causes a dependency on hystrix context initialization for all custom concurrency strategies. Here we add that back in, along with a test to ensure that a custom strategy could still run without an initialized context.
NetflixOSS » Hystrix » Hystrix-pull-requests #71 FAILURE |
NetflixOSS » Hystrix » Hystrix-pull-requests #72 SUCCESS |
Looks great - thanks for adding the unit test as well that exercises this case. I've gotten Cloudbees happy, so I'm merging this and will release it ASAP as 1.4.2 |
Check if the request log is enabled before requiring the context is initialized.
Thanks! |
Hey @mattrjacobs, how long do you think it'll be until 1.4.2 is published? I want to upgrade all of our stuff ASAP. Thanks again |
This was released yesterday afternoon: https://github.com/Netflix/Hystrix/releases/tag/v1.4.2 |
Doh. Our nexus proxy was caching the absence of it. Thanks again! |
@mattrjacobs we're having an issue where the pom is defining hystrix's deps as scope runtime: The gradle.properties files claims these are at compile. Did something break in the release? |
This also just got reported in #730 . AFAIK, I didn't change anything that would affect this in the Hystrix code itself. I'm looking through the CI configs to see if anything changed there. |
A suggestion: It would be good to add a note about this here: https://github.com/Netflix/Hystrix/wiki/Plugins#concurrencystrategy If I wouldn't have found this pull request, I would have never guessed that I have to set
to make a custom concurrency strategy work... |
In 706a0f2,
the guard to initialize the request log based on the property was removed. This
causes a dependency on hystrix context initialization for all custom concurrency
strategies.
Here we add that back in, along with a test to ensure that a custom strategy could
still run without an initialized context.
This PR supercedes #718
/cc @mattrjacobs