Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport of #327 #508

Merged
merged 7 commits into from
Jan 14, 2015
Merged

Backport of #327 #508

merged 7 commits into from
Jan 14, 2015

Conversation

mattrjacobs
Copy link
Contributor

This is an updated version of #506. It adds assertions on hook execution.

@mattrjacobs
Copy link
Contributor Author

This pull request asserts that the proper calls on HystrixCommandExecutionHook are made. The bugfixes identified by these assertions are:

  • HystrixBadRequestException flow was not invoking onError()
  • run() throwing an Exception with a successful fallback was invoking onComplete() twice

@mattrjacobs mattrjacobs mentioned this pull request Jan 14, 2015
Closed
@cloudbees-pull-request-builder
Copy link

Hystrix-pull-requests #222 FAILURE
Looks like there's a problem with this pull request

mattrjacobs added a commit that referenced this pull request Jan 14, 2015
@mattrjacobs
Merge pull request #508 from mattrjacobs/backport-327
5ca7810 
Backport of #327
@mattrjacobs mattrjacobs merged commit 5ca7810 into Netflix:1.3.x Jan 14, 2015
@mattrjacobs mattrjacobs deleted the backport-327 branch January 14, 2015 04:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattrjacobs @cloudbees-pull-request-builder