Added thread pool metrics back to execution flow #367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rns 0 in 1.4.x - failing test case
Conflicts: hystrix-core/src/main/java/com/netflix/hystrix/HystrixThreadPoolMetrics.java
…ompletion() in AbstractCommand
|
Hystrix-pull-requests #190 SUCCESS |
|
Travis failed, but it looks unrelated. Opened #368 to track that. |
mattrjacobs
added a commit
that referenced
this pull request
Dec 17, 2014
Added thread pool metrics back to execution flow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calls to
threadPool.markThreadExecution()andthreadPool.markThreadCompletion()got removed in the 1.3 -> 1.4 rewrite. This adds them back and gets the unit tests contributed by @nurkiewicz working. Thanks for those, @nurkiewicz!