Added supports for setting threadPoolProperties through @HystrixCommand annotation

[yuhanz]

The @HystrixCommand annotation is creating the threadPool using the default settings. we'd like to make the threadPool configurable as part of the annotation.

[cloudbees-pull-request-builder]

Hystrix-pull-requests #156 FAILURE
Looks like there's a problem with this pull request

[yuhanz]

The build inherited the failed test case since last pull request. The test case is inside hystrix-core, which wasn't modified in this pull request (only at hystrix-avanica).

[benjchristensen]

@dmgcodevil can you please review these changes?

[dmgcodevil]

I added comments for the code lines. Ben could you please check my comments (maybe you can suggest better way)? Also I was planning add ability to annotate whole class to implement "default" properties feature. I gonna start implementation in the near future.

[cloudbees-pull-request-builder]

Hystrix-pull-requests #158 FAILURE
Looks like there's a problem with this pull request

[yuhanz]

ok I just made the change accordingly to use ConfigurationManager, and got rid of the if-else ladder.

I tried locally with debugger. it works. Please review. thanks

[dmgcodevil]

Thanks, looks better. Update README as well. But I still see few places for improvements, please fix them.

[cloudbees-pull-request-builder]

Hystrix-pull-requests #159 FAILURE
Looks like there's a problem with this pull request

[yuhanz]

I did the refactoring accordingly, and added some test cases.

It ended up discovering that metricsRollingStatisticalWindowInMilliseconds and metricsRollingStatisticalWindowBuckets wouldn't be set correctly.
"hystrix.threadpool.{}.metricsRollingStatisticalWindowInMilliseconds" doesn't seem to work.. I'm guessing metricsRollingStatisticalWindow* might be using a different prefix in the ConfigurationManager.

so what's the correct prefix for metrixRollingStatisticalWindow* ?

Thank you.

[dmgcodevil]

As I know this is property of Hystrix command:

hystrix.command.default.metrics.rollingStats.timeInMilliseconds

[cloudbees-pull-request-builder]

Hystrix-pull-requests #160 FAILURE
Looks like there's a problem with this pull request

[dmgcodevil]

@benjchristensen I finished reviewing of this PL, could you please merge it ? Thanks.
@yuhanz Seems like you need also make same pool request for https://github.com/Netflix/Hystrix/tree/1.3.x branch.

[yuhanz]

cool thanks. I made another pull request at branch 1.3.x: #329