New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove possible NPE #1469

Merged

mattrjacobs merged 1 commit into Netflix:master from petercla:master

Feb 7, 2017

petercla commented Jan 31, 2017

No description provided.


          Remove possible NPE

519e7c8

Contributor

spencergibb commented Jan 31, 2017

Doesn't seem any different to me.

Author

petercla commented Jan 31, 2017 via email

Hello, I am guessing the code is accessed by multiple threads so the call to the first top.get() may return a non null result but that doesn’t meant that the second call to top.get will return a non null result. Could be that a different thread pop’ed the stack to leave null From: Spencer Gibb [mailto:[email protected]] Sent: 31 January 2017 14:02 To: Netflix/Hystrix <[email protected]> Cc: Clarke, Peter <[email protected]>; Author <[email protected]> Subject: Re: [Netflix/Hystrix] Remove possible NPE (#1469) Doesn't seem any different to me. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FNetflix%2FHystrix%2Fpull%2F1469%23issuecomment-276370242&data=01%7C01%7Cpeter.clarke2%40fisglobal.com%7Cbc85de4c8de14945a0ac08d449e1c6ab%7Ce3ff91d834c84b15a0b418910a6ac575%7C0&sdata=i0%2F%2BKKMRoAFnWVdmOX%2BA1i48b4t5x7cp49o7SfyJ2H4%3D&reserved=0>, or mute the thread<https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAYQjRSBjh333KSV-ywIl5mV9Oj3bHVn-ks5rXz7qgaJpZM4Lynl1&data=01%7C01%7Cpeter.clarke2%40fisglobal.com%7Cbc85de4c8de14945a0ac08d449e1c6ab%7Ce3ff91d834c84b15a0b418910a6ac575%7C0&sdata=29dOVV%2BrMXTZ1MJTdfgmD7Pl0RLXqFzdK%2FpvJLjvRIg%3D&reserved=0>. The information contained in this message is proprietary and/or confidential. If you are not the intended recipient, please: (i) delete the message and all copies; (ii) do not disclose, distribute or use the message in any manner; and (iii) notify the sender immediately. In addition, please be aware that any message addressed to our domain is subject to archiving and review by persons other than the intended recipient. Thank you.

Contributor

mattrjacobs commented Feb 7, 2017

Yeah, this looks like a good change to me. Thanks for the PR @petercla !

If the internal state is getting mutated by a different thread while peek is inflight, then this method is safer.

mattrjacobs merged commit 7fdda15 into Netflix:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet