Add with-context macro for conviently wrapping collapsers in thier own context

[dinedal]

Closes #132

[cloudbees-pull-request-builder]

Hystrix-pull-requests #7 FAILURE
Looks like there's a problem with this pull request

[dinedal]

Is there any easy way to run tests locally for the clojure bindings? without a project.clj, there's no way to invoke lein test

[cloudbees-pull-request-builder]

Hystrix-pull-requests #8 FAILURE
Looks like there's a problem with this pull request

[dinedal]

I can't recreate this issue locally, even after putting in the effort to get tests working at all.

@daveray I would appreciate some help here, if possible

[daveray]

@dinedal you're code looks fine. Maybe @benjchristensen can shed some light on this test failure. It doesn't look related to the Clojure code though.

You can run the tests with ./gradlew test.

[daveray]

... and for what it's worth, you can get an nrepl server to connect to (from your editor, lein repl, etc) with gradlew nrepl. I usually just have vim connected to that and run the tests from vim.

[daveray]

@dinedal looks like there's now a failure in the tests with your changes. There's no need to wrap (to-upper-collapser) in a context because the tests themselves are already wrapped with a context management fixture.

[dinedal]

@daveray Thanks, I can revert and push it again

[cloudbees-pull-request-builder]

Hystrix-pull-requests #9 FAILURE
Looks like there's a problem with this pull request

[dinedal]

@daveray @benjchristensen

Thanks for the info on how to run the tests! That worked, but locally I see 100% success now. Any pointers would be helpful, would love to contribute to this project.

[daveray]

@dinedal your new changes work fine for me. I wonder if it should be with-request-context just to be explicit?

I'll merge them in once I get confirmation from @benjchristensen that the cloudbees errors are unrelated. I seem to recall there was a concurrency related test that worked some places, but failed others.

[dinedal]

WRT the name, I can make that change tomorrow no problem.

On Apr 2, 2013, at 9:08 PM, Dave Ray [email protected] wrote:

@dinedal https://github.com/dinedal your new changes work fine for me. I
wonder if it should be with-request-context just to be explicit?

I'll merge them in once I get confirmation from
@benjchristensenhttps://github.com/benjchristensenthat the cloudbees
errors are unrelated. I seem to recall there was a
concurrency related test that worked some places, but failed others.

—
Reply to this email directly or view it on
GitHubhttps://github.com//pull/135#issuecomment-15816751
.

[cloudbees-pull-request-builder]

Hystrix-pull-requests #10 FAILURE
Looks like there's a problem with this pull request

[benjchristensen]

Ignore the CloudBees issues ... I have some non-deterministic tests that work on our internal build system but not CloudBees ... one of these days I'll get those fixed.

@daveray has confirmed this is good so I'll merge.