Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A couple approaches to fix HystrixObservableCollapser not producing values #1043

Merged
merged 2 commits into from
Jan 11, 2016

Conversation

mattrjacobs
Copy link
Contributor

Addresses #955

  1. Batch command failure was not handing this exception out to each collapser waiting for a value
  2. Synchronous error thrown in submit request changed to Observable.error(...)
  3. Cached HystrixCollapserProperties in unit test to ensure we didn't hit Archauis bottleneck
  4. Added unit test for batch command failing and matched behavior to HystrixCollapser

…alues

1) Batch command failure was not handing this exception out to each collapser waiting for a value
2) Synchronous error thrown in submit request changed to Observable.error(...)
3) Cached HystrixCollapserProperties in unit test to ensure we didn't hit Archauis bottleneck
4) Added unit test for batch command failing and matched behavior to HystrixCollapser
@cloudbees-pull-request-builder

NetflixOSS » Hystrix » Hystrix-pull-requests #299 SUCCESS
This pull request looks good

mattrjacobs added a commit that referenced this pull request Jan 11, 2016
A couple approaches to fix HystrixObservableCollapser not producing values
@mattrjacobs mattrjacobs merged commit 4816163 into Netflix:master Jan 11, 2016
@mattrjacobs mattrjacobs deleted the find-collapser-missing-value branch January 11, 2016 19:38
@cloudbees-pull-request-builder

NetflixOSS » Hystrix » Hystrix-pull-requests #300 SUCCESS
This pull request looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants