Fix decimal parsing issue for scientific notation in DbfNumericDecimalField (#57) #58
Conversation
…lField The `DbfNumericDecimalField` class in the `NetTopologySuite.IO.Esri` library failed to correctly parse numeric fields in scientific notation (e.g., "9.095630227029324e-05") due to the use of `decimal.Parse` without `NumberStyles.Float`. This resulted in a format exception. Updated the parsing logic to use `NumberStyles.Float` with `decimal.Parse` to handle scientific notation correctly. Affected class: `DbfNumericDecimalField`
|
|
|
Hi @DiegoNetoMartins, thank you for identifying this issue and suggesting a fix. Your proposed modification looks solid. To ensure comprehensive coverage, could you please add a unit test to validate this change? You might find it helpful to follow the existing test for the Issue049, which also relates to the |
Hi @KubaSzostak , Thank you for your feedback. I have added a unit test to validate the change related to DbfNumericDecimalField. You can find the changes in the following commit: d1f50ed Please let me know if there are any further adjustments needed. Looking forward to your review! Best regards, |
|
Thank you @DiegoNetoMartins for fixing the issue and and for adding the unit test. The changes look great, and the test case covers the modification well. Looking forward to any future collaborations! |
Hi @KubaSzostak, thanks for the feedback! Could you let me know when these updates will be included in the NuGet package? |
|
@FObermaier, can we push the latest fixes to the NuGet repository? |
|
@KubaSzostak, done. |
This PR addresses the issue with decimal parsing in scientific notation described in issue #57 .
Fixes #57