Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--overwrite-old-items flag is failing because of equality comparison on semVerLikeVersion and instead duplicates are left in the feed #630

Merged

Conversation

robbiehinch
Copy link

No description provided.

…on semVerLikeVersion and instead duplicates are left in the feed
@Deadpikle
Copy link
Member

@robbiehinch Thank you very much for filing a bug AND a PR to fix it AND a unit test to make sure it stays fixed! Appreciate it very much!

I did go ahead and expand the test just a little bit to make sure that it works if OverwriteOldItemsInAppcast is false and to use semantic versioning.

Again, thank you!! :-)

@robbiehinch robbiehinch deleted the fix-duplicate_remove_failing branch November 19, 2024 17:14
@robbiehinch
Copy link
Author

@Deadpikle thank you for continuing to maintain this project which has been very useful for my team. We're using it in a github build action at the moment, by installing it like this:

dotnet tool install --global NetSparkleUpdater.Tools.AppCastGenerator

Can you help me to understand when this change would make it into the package that is getting retrieved using dotnet tool install, please?

@Deadpikle
Copy link
Member

Should already be available. It was deployed yesterday. :)

@Deadpikle
Copy link
Member

You can see on the NuGet feed here: https://www.nuget.org/packages/NetSparkleUpdater.Tools.AppCastGenerator/2.8.3

You're looking for v2.8.3.

Glad to know it's been helpful!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants