Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refine some codes #29

Merged
merged 4 commits into from
Oct 16, 2014
Merged

refine some codes #29

merged 4 commits into from
Oct 16, 2014

Conversation

yrom
Copy link

@yrom yrom commented Oct 13, 2014

No description provided.

@andrewleo
Copy link
Member

十分感谢您提的pull request,很优秀的代码!不过如果能做以下完善就更好了:
(1)建议将commit rebase成一个
(2)方法加上注释,类加上注释以及作者(均英文),这样更规范些
如果方便,建议您能再优化下重提pull request;或者,也可以交由Emmagee团队对代码进行整理。
期待您优化后新的pull request :)

@yrom
Copy link
Author

yrom commented Oct 15, 2014

因为你说要提交给 develop 啊~~

------------------ Original ------------------
From: "Liu Xiao"[email protected];
Date: 2014年10月15日(星期三) 下午5:02
To: "NetEase/Emmagee"[email protected];
Cc: "yrom"[email protected];
Subject: Re: [Emmagee] refine some codes (#29)

十分感谢您提的pull request,很优秀的代码!不过如果能做以下完善就更好了:
(1)建议将commit rebase成一个
(2)方法加上注释,类加上注释以及作者(均英文),这样更规范些
如果方便,建议您能再优化下重提pull request;或者,也可以交由Emmagee团队对代码进行整理。
期待您优化后新的pull request :)


Reply to this email directly or view it on GitHub.

refactor ListAdapter;
Change settings to SharedPreferences from Properties;
set File name to mail attachment;
check read_logs permission
@yrom
Copy link
Author

yrom commented Oct 15, 2014

已经合并为一个 commit

@andrewleo andrewleo merged commit 1350be7 into NetEase:develop Oct 16, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants