new resource quota rules #234
Conversation
suhasbshekar
requested review from
carchi8py,
chuyich and
wenjun666
as code owners
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| resource.Test(t, resource.TestCase{ | ||
| PreCheck: func() { ntest.TestAccPreCheck(t) }, | ||
| ProtoV6ProviderFactories: ntest.TestAccProtoV6ProviderFactories, | ||
| Steps: []resource.TestStep{ |
There was a problem hiding this comment.
Can we have a test with the required parameters only if it makes sense?
There was a problem hiding this comment.
the current test covers all scenarios, so it should be fine I think
There was a problem hiding this comment.
ok. I just want to make sure if the user provides only required, very limited basic parameters and it should work.
examples/resources/netapp-ontap_storage_quota_rules/resource.tf
Outdated
Show resolved
Hide resolved
| } | ||
| data.Files = objectValue | ||
| data.ID = types.StringValue(restInfo.UUID) | ||
|
|
There was a problem hiding this comment.
Nope, not required here, I tested it again, its good, successfully creating, modifying, deleting and updating the state file
There was a problem hiding this comment.
Is user not returned then?
There was a problem hiding this comment.
user can be added only through input and when used as input state is updated, if not, its always empty and its not modifiable too
#136