-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new data source for cifs share and shares #154
Merged
wenjun666
merged 10 commits into
integration/main
from
28-new-data-source-protocolscifsshares
Apr 5, 2024
Merged
Add new data source for cifs share and shares #154
wenjun666
merged 10 commits into
integration/main
from
28-new-data-source-protocolscifsshares
Apr 5, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wenjun666
requested review from
carchi8py,
chuyich and
suhasbshekar
as code owners
March 26, 2024 21:44
The following files are missing '## Example Usage': docs/data-sources/protocols_cifs_share_data_source.md |
carchi8py
reviewed
Apr 4, 2024
query := r.NewQuery() | ||
query.Add("name", name) | ||
query.Add("svm.name", svmName) | ||
// query.Set("name", name) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Go ahead and delete this
…m-provider-netapp-ontap into 28-new-data-source-protocolscifsshares
carchi8py
approved these changes
Apr 4, 2024
suhasbshekar
approved these changes
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.