40 enhancement netapp ontap storage snapshot policy need to support import #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wenjun666
requested review from
carchi8py,
chuyich and
suhasbshekar
as code owners
chuyich
reviewed
Dec 4, 2023
| ### Terraform Import | ||
| For example | ||
| ```shell | ||
| terraform import netapp-ontap_storage_snapshot_policy_resource.example exp1,svm1,cluster4 |
There was a problem hiding this comment.
"exp1" might confuse people. Maybe use something like "policy1" or "snp_policy1"
chuyich
reviewed
Dec 4, 2023
| ```terraform | ||
| import { | ||
| to = netapp-ontap_storage_snapshot_policy_resource.exp_import | ||
| id = "exp1,svm1,cluster4" |
There was a problem hiding this comment.
same as here "exp1" seems not really represent as the snapshot policy name (line 107 & 108)
chuyich
reviewed
Dec 4, 2023
| ```terraform | ||
| # __generated__ by Terraform | ||
| # Please review these resources and move them into your main configuration files. | ||
| # __generated__ by Terraform from "exp1,svm1,cluster4" |
There was a problem hiding this comment.
same as these lines 119, 120, 122
chuyich
reviewed
Dec 4, 2023
| ImportState: true, | ||
| ImportStateId: fmt.Sprintf("%s,%s,%s", "tfimportpolicy", "automation", "cluster4"), | ||
| Check: resource.ComposeTestCheckFunc( | ||
| resource.TestCheckResourceAttr("netapp-ontap_protocols_nfs_export_policy_resource.example", "name", "tfimportpolicy"), |
There was a problem hiding this comment.
the resource address is not about storage policy
chuyich
requested changes
Dec 4, 2023
carchi8py
approved these changes
Dec 12, 2023
…age_snapshot_policy-need-to-support-import
chuyich
requested changes
Dec 12, 2023
| First create the block | ||
| ```terraform | ||
| import { | ||
| to = netapp-ontap_storage_snapshot_policy_resource.exp_import |
There was a problem hiding this comment.
It does not match the example in line 120 (exp_import vs policy1_import)
chuyich
approved these changes
Dec 14, 2023
carchi8py
deleted the
40-enhancement-netapp-ontap_storage_snapshot_policy-need-to-support-import
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.