feat: taro 组件支持字节 PaymentChannelSelect 组件 #16889
Open
+24
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tutuxxx
requested changes
Nov 19, 2024
| @@ -168,5 +168,15 @@ export const components = { | |||
| fixed: _false, | |||
| 'left-right-padding': _empty, | |||
| bindError: _empty | |||
| }, | |||
| PaymentChannelSelect:{ | |||
There was a problem hiding this comment.
请保证代码风格，如：Missing space before value for key 'PaymentChannelSelect'
| export const RateButton = 'rate-button' | ||
| export const OpenData = 'open-data' | ||
| export const AwemeUserCard = 'aweme-user-card' | ||
| export const PaymentChannelSelect = 'payment-channel-select' |
This was referenced Nov 23, 2024
This was referenced Nov 30, 2024
This was referenced Nov 30, 2024
tutuxxx
reviewed
Dec 2, 2024
.prettierrc
Outdated
| @@ -1,5 +1,6 @@ | |||
| { | |||
| "semi": false, | |||
| "singleQuote": true, | |||
| "printWidth": 120 | |||
| "printWidth": 120, | |||
| "trailingComma": "none" | |||
There was a problem hiding this comment.
这个这个代码之前本身风格配置就有问题，按历史逻辑来讲是 trailingComma 但是代码内部也没有做格式化，导致ide根据这个格式化会失败（多了很多不符合预期的diff），可以把这个文件不修改，但是本周还是需要社区整体治理一下
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
这个 PR 做了什么? (简要描述所做更改)
支持 Taro 调用字节小程序的 PaymentChannelSelect 组件
这个 PR 是什么类型? (至少选择一个)
这个 PR 涉及以下平台: