Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vite): taro 相关的依赖在小程序端打包成taro chunk & 修改 getComputedStyle、URL、document、window、history、location 浏览器环境中的全局对象的变量命名,避免 vite dev模式下的报错 #16100

Merged
merged 4 commits into from
Jul 15, 2024

Conversation

ZEJIA-LIU
Copy link
Contributor

这个 PR 做了什么? (简要描述所做更改)

  1. taro 相关的依赖在小程序端打包成taro chunk
  2. 修改 getComputedStyle、URL、document、window、history、location 浏览器环境中的全局对象的变量命名,避免 vite dev模式下的报错

这个 PR 是什么类型? (至少选择一个)

  • 错误修复(Bugfix) issue: fix #
  • 新功能(Feature)
  • 代码重构(Refactor)
  • TypeScript 类型定义修改(Typings)
  • 文档修改(Docs)
  • 代码风格更新(Code style update)
  • 其他,请描述(Other, please describe):

这个 PR 涉及以下平台:

  • 所有小程序
  • 微信小程序
  • 支付宝小程序
  • 百度小程序
  • 字节跳动小程序
  • QQ 轻应用
  • 京东小程序
  • 快应用平台(QuickApp)
  • Web 平台(H5)
  • 移动端(React-Native)
  • 鸿蒙(harmony)

@ZEJIA-LIU ZEJIA-LIU requested a review from koppthe July 15, 2024 09:01
Copy link

codecov bot commented Jul 15, 2024

Codecov Report

Attention: Patch coverage is 90.90909% with 1 line in your changes missing coverage. Please review.

Project coverage is 61.04%. Comparing base (a7fcf67) to head (cba986c).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##              4.x   #16100   +/-   ##
=======================================
  Coverage   61.04%   61.04%           
=======================================
  Files         445      445           
  Lines       22937    22937           
  Branches     4781     4782    +1     
=======================================
  Hits        14003    14003           
  Misses       7957     7957           
  Partials      977      977           
Flag Coverage Δ
taro-cli 73.67% <ø> (ø)
taro-runtime 59.83% <90.90%> (ø)
taro-web 52.75% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
packages/taro-runtime/src/bom/URL.ts 45.98% <100.00%> (ø)
packages/taro-runtime/src/bom/getComputedStyle.ts 66.66% <100.00%> (ø)
packages/taro-runtime/src/bom/window.ts 63.79% <100.00%> (ø)
packages/taro-runtime/src/utils/router.ts 40.00% <100.00%> (ø)
packages/taro-runtime/src/bom/location.ts 16.56% <66.66%> (ø)

@ZEJIA-LIU ZEJIA-LIU merged commit 360752b into 4.x Jul 15, 2024
29 checks passed
@ZEJIA-LIU ZEJIA-LIU deleted the feat/vite-runner-taro-chunk branch July 15, 2024 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants