Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for mac os #18

Merged
merged 3 commits into from
Jul 26, 2019
Merged

Fix for mac os #18

merged 3 commits into from
Jul 26, 2019

Conversation

katcipis
Copy link
Contributor

@katcipis katcipis commented Jul 25, 2019

I wanted to give support to macos on CI but from the docs:

https://docs.travis-ci.com/user/docker/

We do not currently support use of Docker on macOS.

Since the core objective is support to docker stuff, we are not going to have support for mac os on the CI and it makes kinda hard for me to test this, help will be needed from mac users x_x

@katcipis katcipis self-assigned this Jul 25, 2019
@katcipis katcipis requested review from i4ki and matheusvill July 25, 2019 01:23
This is important to make things work on Mac OS
@katcipis katcipis changed the title WIP: Fix for mac os Fix for mac os Jul 25, 2019
There is not support for docker on OSX on TravisCI =(
Copy link
Collaborator

@kamilash kamilash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@katcipis katcipis merged commit 5fe226a into master Jul 26, 2019
@katcipis katcipis deleted the fixMac branch July 26, 2019 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants