Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

paper-tab still visible even though cosmoz-tab has hidden attribute #26

Closed
plequang opened this issue Oct 23, 2017 · 0 comments · Fixed by #28
Closed

paper-tab still visible even though cosmoz-tab has hidden attribute #26

plequang opened this issue Oct 23, 2017 · 0 comments · Fixed by #28

Comments

@plequang
Copy link
Contributor

Description

The problem occurs only when using Polymer 2.0.

When using

<cosmoz-tab hidden heading="tab">

The content of the tab is not displayed, but the corresponding paper-tab is still visible.

See the second tab demo at http://127.0.0.1:8081/components/cosmoz-tabs/demo/tab.html

The problem does not occur when using Polymer 1.x and shady dom.

I think this is caused by a problem of iron-flex-layout version 1.x, that has a rule for hidden attribute that "leaks" in all dom tree. This rule has been removed from iron-flex-layout v2.
See PolymerElements/iron-flex-layout#86
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Hidden paper-tab should have display none plumelo/cosmoz-tabs
1 participant
@plequang