-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Views generic #18
base: master
Are you sure you want to change the base?
Views generic #18
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, we have a lot of helper functions. Great work listing them all. Looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good stuff.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is way too verbose and this kind of "disconnected" documentation for methods will never be updated.
Link to the generated docs for each behavior instead and make sure it's updated in the annotated documentation for each file, see http://localhost:3000/polymer/cz-behaviors/index.html
4107dbe
to
95af286
Compare
Pull requests has been issued in cosmoz-frontend to update in file documentation: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should still drop the list of methods from this and only maintain the links to the automatic documentation.
We can keep the behavior description though.
Yes, that was my intent to drop the lists and link directly. I have been awaiting review of the automatic documentation to see if I was on the right track, and now as one is merged then I can continue removing the lists. |
95af286
to
64a3f88
Compare
…mentation and to dos for documentation on Webcomponents.org. docs/views/10-generic.rst, adding see also links to local documentation and to do for documentation on Webcomponents.org
… with local automatic documentation references. docs/views/10-generic.rst, removing method lists for behaviors with local automatic documentation
129ddec
to
8ba43e4
Compare
Adding and updating information, most notably a view behavior reference list for all behaviors I found used in the views. This is in response to the 'Document view behaviors' todo note.