-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update generic tests for changes in AbstractAlgebra. #912
Conversation
I'm actually not sure why the CI fails here. I guess it's using a released version of AbstractAlgebra which doesn't contain the new function. Should I update the version number in Nemo's compat with this PR? |
The tests are using AbstractAlgebra v0.11.1, which was tagged yesterday or the day before. |
Indeed, the latest AA release is v0.11.1 and is used in the tests, but |
Co-authored-by: Rafael Fourquet <[email protected]>
Co-authored-by: Rafael Fourquet <[email protected]>
There's also can_solve_with_solution_lu which only exists in master. That's why the tests still fail. |
Yes I just updated it, I guess tests should pass now. |
The failure is unrelated and can be ignored. |
* Update generic tests for changes in AbstractAlgebra.
This probably shouldn't be strictly necessary, but the Nemo generic tests were calling the internal AbstractAlgebra functions which changed. Therefore this PR is necessary to adjust for the changes over there.
This probably has a bearing on #909