Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update generic tests for changes in AbstractAlgebra. #912

Merged
merged 5 commits into from
Nov 5, 2020

Conversation

wbhart
Copy link
Contributor

@wbhart wbhart commented Nov 5, 2020

This probably shouldn't be strictly necessary, but the Nemo generic tests were calling the internal AbstractAlgebra functions which changed. Therefore this PR is necessary to adjust for the changes over there.

This probably has a bearing on #909

@wbhart
Copy link
Contributor Author

wbhart commented Nov 5, 2020

I'm actually not sure why the CI fails here. I guess it's using a released version of AbstractAlgebra which doesn't contain the new function.

Should I update the version number in Nemo's compat with this PR?

@thofma
Copy link
Member

thofma commented Nov 5, 2020

The tests are using AbstractAlgebra v0.11.1, which was tagged yesterday or the day before.

@rfourquet
Copy link
Contributor

I guess it's using a released version of AbstractAlgebra which doesn't contain the new function.

Indeed, the latest AA release is v0.11.1 and is used in the tests, but can_solve_with_solution_fflu is only present on the master branch. So this PR will have to wait for a new AA release, and then Nemo will have to depend on AA v0.11.2. But as it's just test code with only a couple of lines, I rather suggest to make the the use of the functions conditional. I will comment inline.

test/generic/Matrix-test.jl Outdated Show resolved Hide resolved
test/generic/Matrix-test.jl Outdated Show resolved Hide resolved
wbhart and others added 2 commits November 5, 2020 12:14
@wbhart
Copy link
Contributor Author

wbhart commented Nov 5, 2020

There's also can_solve_with_solution_lu which only exists in master. That's why the tests still fail.

test/generic/Matrix-test.jl Outdated Show resolved Hide resolved
test/generic/Matrix-test.jl Outdated Show resolved Hide resolved
@rfourquet
Copy link
Contributor

There's also can_solve_with_solution_lu which only exists in master. That's why the tests still fail.

Yes I just updated it, I guess tests should pass now.

@wbhart
Copy link
Contributor Author

wbhart commented Nov 5, 2020

The failure is unrelated and can be ignored.

@thofma thofma merged commit 4762f59 into Nemocas:master Nov 5, 2020
thofma pushed a commit that referenced this pull request Dec 12, 2020
* Update generic tests for changes in AbstractAlgebra.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants