moved two functions from Oscar to Nemo #1519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is not yet satisfactory: - Should `embed` return something? The `embed(k::T, K::T) where T <: FinField` method returns a mapping, but the documentation does not state what is returned, and the code that calls `embed` seems to ignore the return value. - Tests and documentation are missing.
Codecov Report
@@ Coverage Diff @@
## master #1519 +/- ##
==========================================
- Coverage 82.75% 82.73% -0.03%
==========================================
Files 95 95
Lines 37186 37189 +3
==========================================
- Hits 30773 30768 -5
- Misses 6413 6421 +8
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Looks good. I will merge once we do the next breaking release. |
lgoettgens
added a commit
to oscar-system/Oscar.jl
that referenced
this pull request
Sep 13, 2023
lgoettgens
added a commit
to oscar-system/Oscar.jl
that referenced
this pull request
Sep 13, 2023
lgoettgens
added a commit
to oscar-system/Oscar.jl
that referenced
this pull request
Sep 14, 2023
thofma
pushed a commit
to oscar-system/Oscar.jl
that referenced
this pull request
Sep 14, 2023
* Bump compats * Remove functions moved to Nemo (Nemocas/Nemo.jl#1519) * Fix `ZZ` printing (Nemocas/Nemo.jl#1506) * Fix `identity_map` docstrings (Nemocas/AbstractAlgebra.jl#1431) * Fix `PosInf` docstring (Nemocas/Nemo.jl#1528) * Adapt doctests to new printing for maps Nemocas/AbstractAlgebra.jl#1424
fieker
pushed a commit
to oscar-system/Oscar.jl
that referenced
this pull request
Sep 29, 2023
* Bump compats * Remove functions moved to Nemo (Nemocas/Nemo.jl#1519) * Fix `ZZ` printing (Nemocas/Nemo.jl#1506) * Fix `identity_map` docstrings (Nemocas/AbstractAlgebra.jl#1431) * Fix `PosInf` docstring (Nemocas/Nemo.jl#1528) * Adapt doctests to new printing for maps Nemocas/AbstractAlgebra.jl#1424
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not yet satisfactory:
embedreturn something? Theembed(k::T, K::T) where T <: FinFieldmethod returns a mapping, but the documentation does not state what is returned, and the code that callsembedseems to ignore the return value.(And
Run tests / test (~1.10.0-0, ubuntu-latest) (pull_request)got canceled.)