Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Calcium as binary dependency #1067

Merged
merged 1 commit into from
May 20, 2021
Merged

Add Calcium as binary dependency #1067

merged 1 commit into from
May 20, 2021

Conversation

thofma
Copy link
Member

@thofma thofma commented May 19, 2021

No description provided.

@thofma thofma force-pushed the th/calcium branch 2 times, most recently from 7377ea5 to 8369a00 Compare May 19, 2021 15:51
@thofma thofma mentioned this pull request May 19, 2021
@codecov
Copy link

codecov bot commented May 19, 2021

Codecov Report

Merging #1067 (19fb030) into master (8db7bdb) will increase coverage by 1.87%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1067      +/-   ##
==========================================
+ Coverage   83.32%   85.19%   +1.87%     
==========================================
  Files          63       63              
  Lines       22117    22262     +145     
==========================================
+ Hits        18429    18967     +538     
+ Misses       3688     3295     -393     
Impacted Files Coverage Δ
src/Nemo.jl 28.32% <ø> (ø)
src/flint/FlintTypes.jl 92.39% <0.00%> (+0.05%) ⬆️
src/flint/fq_rel_series.jl 93.70% <0.00%> (+4.96%) ⬆️
src/flint/fmpq_abs_series.jl 92.01% <0.00%> (+6.88%) ⬆️
src/flint/fmpz_abs_series.jl 94.66% <0.00%> (+9.78%) ⬆️
src/flint/fmpz_mod_abs_series.jl 87.53% <0.00%> (+10.35%) ⬆️
src/flint/fmpq_rel_series.jl 94.53% <0.00%> (+10.35%) ⬆️
src/flint/nmod_abs_series.jl 88.96% <0.00%> (+10.74%) ⬆️
src/flint/fq_abs_series.jl 86.34% <0.00%> (+10.85%) ⬆️
src/flint/nmod_rel_series.jl 83.13% <0.00%> (+12.03%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8db7bdb...19fb030. Read the comment docs.

(Fixes also a problem with libantic on julia < 1.3)
@thofma
Copy link
Member Author

thofma commented May 19, 2021

Should be good to go as soon as the lights turn green.

I also found and fixed a bug on julia < 1.3 regarding libantic. We were using the wrong version.

@thofma thofma merged commit 276d812 into master May 20, 2021
@thofma thofma deleted the th/calcium branch September 9, 2021 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants