Add initial support for Markdown #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NeilAn99
reviewed
Sep 22, 2022
| let pattern = /\*\*(?:\\.|[^\*\*])*\*\*/gm; | ||
| let matchIndexes = []; | ||
| let match; | ||
| while( match = pattern.exec(theLine) ){ |
There was a problem hiding this comment.
Can you add a comment for this while loop to explain what it does
NeilAn99
reviewed
Sep 22, 2022
generateHTML.js
Outdated
| matchIndexes.push(match.index); | ||
| matchIndexes.push(pattern.lastIndex); | ||
| } | ||
| console.log(matchIndexes); |
There was a problem hiding this comment.
Can you remove this console.log
|
updated with requested changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code resolves issue 6.
Users now have the ability to parse markdown files to generate an html file, as well as parsing through each line of the markdown file to find pieces of text that are meant to be builded (with the "**" symbols).
This was accomplished by modifying generateHTML.js, and adding a new function called readMdFile. I also changed readFile to readTextFile to differentiate between the two.
Also, I added /dist folder to .gitignore to prevent uploading the generated test websties to git.
I also modified main.js to represent a version bump.