/atom/proc/examine() rework. #4836
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MistakeNot4892
added
the
work in progress
MistakeNot4892
force-pushed
the
rework/examine
branch
from
842843d to
666f6ea
Compare
MistakeNot4892
force-pushed
the
rework/examine
branch
from
666f6ea to
78a388c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO
Description of changes
examine()is nowexamined_by().examined_by()assembles string lists via three procs, in order:get_examine_header()get_examine_strings()get_examine_hints()Why and what will this PR improve
Allows control over ordering of examination output.
Nicer, more readable code.
Probably more performant given the removed string ops.
Authorship
Myself.
Changelog
Nothing player-facing.