Remove and condense unnecessary side-overrides in core code #4678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -719,11 +719,8 @@ Turf and target are seperate in case you want to teleport some distance from a t | |||
| /obj/item/weldingtool/can_puncture() | |||
| return 1 | |||
There was a problem hiding this comment.
This should return isOn() I suspect.
There was a problem hiding this comment.
Not blocking, just a note.
out-of-phaze
force-pushed
the
codequality/side-override-audit
branch
from
9223dba to
67ce8b8
Compare
| @@ -378,7 +378,7 @@ | |||
| return ..(user, distance, "", jointext(desc_comp, "<br/>")) | |||
|
|
|||
| /obj/item/check_mousedrop_adjacency(var/atom/over, var/mob/user) | |||
| . = (loc == user && istype(over, /obj/screen/inventory)) || ..() | |||
There was a problem hiding this comment.
I think /inventory might be correct, there's no need to drag and drop over other elements that I can think of.
There was a problem hiding this comment.
/obj/item/organ/internal/augment/active/cyberbrain/handle_mouse_drop(atom/over, mob/user, params)
if(!istype(over, /obj/screen))
attack_self(user)
return TRUE
. = ..()
dunno, but it's not the only place that checks for specifically screen as opposed to inventory. was just going for what current code did, since by checking both with || we're defaulting to the less-specific one
MistakeNot4892
previously approved these changes
Dec 27, 2024
out-of-phaze
force-pushed
the
codequality/side-override-audit
branch
from
67ce8b8 to
6e9683e
Compare
MistakeNot4892
approved these changes
Dec 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Removes or condenses a lot of unnecessary side-overrides in core code.
Some of these commits are going to be sent to stable/staging as applicable because they're fixes rather than code quality edits.Done. #4679Why and what will this PR improve
Found a lot of bugs/bad copypasta and also just improves code quality overall. Simplifies control flow and somewhat improves performance on hot procs like update_icon.
Authorship
Me