Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generalizes the ruin loader. #3657

Merged
merged 1 commit into from
Feb 16, 2024
Merged

Generalizes the ruin loader. #3657

merged 1 commit into from
Feb 16, 2024

Conversation

MistakeNot4892
Copy link
Contributor

Description of changes

  • Renames a bunch of 'ruins' vars to 'template'.
  • Moves planetoid subtemplate selection and spawning onto /datum/level_data.

Why and what will this PR improve

Allows arbitrary levels/non-planetoids to handle POI placement.

Authorship

Myself.

Changelog

Nothing player-facing.

@MistakeNot4892 MistakeNot4892 force-pushed the poiloader branch 3 times, most recently from adcb20c to 81a888a Compare February 3, 2024 13:09
@MistakeNot4892 MistakeNot4892 added the ready for review This PR is ready for review and merge. label Feb 3, 2024
@MistakeNot4892 MistakeNot4892 force-pushed the poiloader branch 3 times, most recently from f3f6653 to b7b6a6f Compare February 4, 2024 07:32
@MistakeNot4892 MistakeNot4892 added this to the r5 milestone Feb 5, 2024
out-of-phaze
out-of-phaze previously approved these changes Feb 12, 2024
View reviewed changes
@comma comma added the has conflicts This PR needs updating and conflict resolution before it can be merged. label Feb 15, 2024
@MistakeNot4892 MistakeNot4892 removed the has conflicts This PR needs updating and conflict resolution before it can be merged. label Feb 15, 2024
@out-of-phaze out-of-phaze merged commit c721b94 into NebulaSS13:dev Feb 16, 2024
11 checks passed
@MistakeNot4892 MistakeNot4892 deleted the poiloader branch March 16, 2024 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@comma comma comma approved these changes

@out-of-phaze out-of-phaze out-of-phaze approved these changes

Assignees
No one assigned
Labels
ready for review This PR is ready for review and merge.
Projects
None yet
Milestone
r5
Development

Successfully merging this pull request may close these issues.
3 participants
@MistakeNot4892 @comma @out-of-phaze