Split disposal.dmi #3621
Merged
Split disposal.dmi #3621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MistakeNot4892
added
the
work in progress
quardbreak
force-pushed
the
pipe-garfield
branch
from
fb898d0 to
471fb49
Compare
MistakeNot4892
added
ready for review
MistakeNot4892
requested changes
Feb 15, 2024
code/modules/recycling/disposal.dm
Outdated
| @@ -310,21 +310,21 @@ var/global/list/diversion_junctions = list() | |||
|
|
|||
| // flush handle | |||
| if(flush) | |||
| overlays += image('icons/obj/pipes/disposal.dmi', "dispover-handle") | |||
| overlays += image(icon, "[icon_state]-handle") | |||
There was a problem hiding this comment.
Should just be overlays += "[icon_state]-handle" here and below, wherever it's just using icon.
Would be good to replace the direct overlays modification with cut_overlays()/add_overlay() if you're willing.
oops forgot to include this push
quardbreak
force-pushed
the
pipe-garfield
branch
from
471fb49 to
37c7b84
Compare
MistakeNot4892
approved these changes
Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Cleanups disposal.dmi and puts disposals objects sprites in separate files.
Removed bunch of unused and old icons:
Updated some code to make animation icon less hardcoded.
Renamed
con[icon_state]to[icon_state]_constructfor better explanation.Open as draft PR. I need to test that nothing is missing.
Why and what will this PR improve
Less icon hoarding, easier to maintain and one step closer to disposals refactor.
Authorship
Myself.