Fixes maploader landmark. #3617
Conversation
MistakeNot4892
force-pushed
the
loaderfix
branch
from
b7cd485 to
9cf745f
Compare
MistakeNot4892
force-pushed
the
loaderfix
branch
from
df2df3e to
7777c39
Compare
|
out-of-phaze/LighthouseRelay@2deefa1 no time to review atm but this is the fix downstream |
|
More or less identical, I just included a New to INITIALIZE_IMMEDIATE and an extra template category to avoid spawning the sub-templates on their own z-levels for testing, |
| /obj/abstract/landmark/map_load_mark/New(loc) | ||
| ..() | ||
| INITIALIZE_IMMEDIATE(/obj/abstract/landmark/map_load_mark) | ||
| /obj/abstract/landmark/map_load_mark/Initialize() |
There was a problem hiding this comment.
according to past-me in #3330 this isn't feasible because this should never run during Initialize() in SSatoms? it should only run at compiletime or in SSmapping, i could be wrong about that though, i can always just revert/issue a fix if it breaks downstream
There was a problem hiding this comment.
I don't really get what past-you means since the only time this would run the actual load logic in Initialize() is if someone spawns it, which is already strongly discouraged. Could mark the type as unspawnable to really formalize that though.
Seems like the actual loading loop got clobbered at some point. Tested on Crux.