Fix temperature sim causing infinite processing #3596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MistakeNot4892
added
awaiting author
out-of-phaze
force-pushed
the
fix/temperature-deprocessing
branch
from
bbd66b0 to
36a1d28
Compare
Improve processing subsystem dequeueing
out-of-phaze
force-pushed
the
fix/temperature-deprocessing
branch
from
36a1d28 to
b9c5b0a
Compare
MistakeNot4892
approved these changes
Jan 19, 2024
MistakeNot4892
added
ready for review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Adds a variable to subsystems,
_internal_name, for better bookkeeping withis_processing. Without this, the conversion from variable name tois_processingis one-way and so we can't tell what subsystem it last queued on. Tracking this helps prevent an issue where trying to dequeue something from SSobjs would instead dequeue it from SStemperature or vice versa. Now, a processing subsystem will only set a dequeued datum'sis_processingto null if it's equal to their_internal_name.Why and what will this PR improve
Fixes lighters that run out of fuel spamming their extinguish message because their
is_processingwas set to null by temperature dequeueing.Authorship
Me.