Z-Mimic: Synchronize with upstream #3365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MistakeNot4892
added
the
work in progress
MistakeNot4892
added
the
stale
MistakeNot4892
added
ready for review
MistakeNot4892
previously approved these changes
Jan 28, 2024
|
DNM: OVERRIDE needs some changes. |
code/__defines/zmimic.dm
Outdated
| @@ -1,7 +1,28 @@ | |||
| #define ZM_DESTRUCTION_TIMER(TARGET) addtimer(CALLBACK(src, TYPE_PROC_REF(/datum, qdel_self)), 10 SECONDS, TIMER_STOPPABLE) | |||
There was a problem hiding this comment.
Suspect this should be TARGET not src.
|
This should be good to go -- I'm not sure about the utility of some of those flags, but they should all work. |
MistakeNot4892
approved these changes
Feb 11, 2024
out-of-phaze
approved these changes
Feb 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates Z-Mimic to the latest (in-dev) version. This should fix several edge case issues, as well as close the discovery loophole without ruining performance like 3-phase ZM. Support is also added for handling of long/wide atoms. ZM performance logging code is present, but define gated off for now.
This is currently not well tested, though the diff changes less than it appears to.