Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sbc.py #287

Closed
wants to merge 2 commits into from
Closed

Update sbc.py #287

wants to merge 2 commits into from

Conversation

shawaj
Copy link
Member

@shawaj shawaj commented Sep 16, 2023

Issue

  • Link:
  • Summary:

How

Screenshots

References

Checklist

  • Tests added
  • Cleaned up commit history (rebase!)
  • Documentation added
  • Thought about variable and method names

@shawaj shawaj requested a review from a team as a code owner September 16, 2023 10:05
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@@ -182,6 +186,10 @@ def sbc_info() -> SBCInfo:
sbc_info = SBCInfo(vendor_id=DeviceVendorID.BOBCAT_RK3566,
vendor_name='Bobcat',
model_name=dev_model)
elif dev_model.lower().find('linxdot') >= 0:
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ccrisan can you confirm what this needs to be?

@shawaj
Copy link
Member Author

shawaj commented Oct 18, 2023

Closing in favour of #290

@shawaj shawaj closed this Oct 18, 2023
@shawaj shawaj deleted the shawaj-patch-1 branch October 18, 2023 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant