Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add packaging to deps #262

Merged
merged 1 commit into from
May 25, 2023
Merged

Add packaging to deps #262

merged 1 commit into from
May 25, 2023

Conversation

ccrisan
Copy link
Contributor

@ccrisan ccrisan commented May 25, 2023

Issue

After switching to pyproject.toml and poetry for packaging and deps management, the packaging Python package would no longer be installed implicitly so we need to add it to deps, explicitly.

  • Link:
  • Summary:

How

Screenshots

References

Checklist

  • Tests added
  • Cleaned up commit history (rebase!)
  • Documentation added
  • Thought about variable and method names

@ccrisan ccrisan requested a review from a team as a code owner May 25, 2023 15:56
@ccrisan ccrisan merged commit 84932e3 into master May 25, 2023
@ccrisan ccrisan deleted the ccrisan/fix-missing-packaging branch May 25, 2023 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shawaj shawaj shawaj approved these changes

@kashifpk kashifpk kashifpk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ccrisan @kashifpk @shawaj