Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pyproject & friends #257

Merged
merged 1 commit into from
May 17, 2023
Merged

Use pyproject & friends #257

merged 1 commit into from
May 17, 2023

Conversation

ccrisan
Copy link
Contributor

@ccrisan ccrisan commented May 11, 2023

Issue

  • Use pyproject.toml to configure the entire project.
  • Use poetry to build the package and manage deps.
  • Use ruff for Python linting.
  • Use bandit for code auditing.
  • Update CI workflows accordingly.

How

Screenshots

References

Checklist

  • Tests added
  • Cleaned up commit history (rebase!)
  • Documentation added
  • Thought about variable and method names

@ccrisan ccrisan requested a review from a team as a code owner May 11, 2023 19:17
@shawaj
Copy link
Member

shawaj commented May 12, 2023

Not really related to this PR, but just an FYI - for the building and shipping to PyPI - instead of manually running that GitHub action you can just use the GitHub Release flow as described here - https://github.com/NebraLtd/hm-pyhelper#releasing

Just using that and setting up the tags and using the auto generated release notes like shown here - https://github.com/NebraLtd/hm-pyhelper/releases/tag/v0.14.10

Then it auto triggers the build and lists all the wheel files and such in the releases.

@shawaj
Copy link
Member

shawaj commented May 12, 2023

also as per comment on hm-diag - wondering if we should add bandit (as we have it in hm-config but not in other repos it seems)

@ccrisan ccrisan force-pushed the ccrisan/pyproject-and-friends branch from a2cd68f to 010bb74 Compare May 15, 2023 09:32
@ccrisan ccrisan force-pushed the ccrisan/pyproject-and-friends branch from 010bb74 to ceb7228 Compare May 16, 2023 09:22
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ccrisan ccrisan merged commit 290a363 into master May 17, 2023
@ccrisan ccrisan deleted the ccrisan/pyproject-and-friends branch May 23, 2023 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants