Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add parsing for onboarding key #238

Merged
merged 2 commits into from
Apr 8, 2023
Merged

feat: add parsing for onboarding key #238

merged 2 commits into from
Apr 8, 2023

Conversation

shawaj
Copy link
Member

@shawaj shawaj commented Apr 6, 2023

Issue

  • Link:
  • Summary: add parsing for onboarding key

How

  • add onboarding key location to all hardware variants
  • add get_onboarding_location function to get correct key
  • add additional tests for new functions and previous
  • add test for non existent i2c bus

Screenshots

References

Closes: #235

Checklist

  • Tests added
  • Cleaned up commit history (rebase!)
  • Documentation added
  • Thought about variable and method names

@shawaj shawaj force-pushed the shawaj/onboarding branch 2 times, most recently from bcd2ad4 to f6315aa Compare April 7, 2023 14:42
- add onboarding key location to all hardware variants
- add get_onboarding_location function to get correct key
- add additional tests for new functions and previous
- add test for non existent i2c bus

Closes: #235
@shawaj shawaj force-pushed the shawaj/onboarding branch from 671b534 to 30b14f5 Compare April 7, 2023 15:05
@shawaj shawaj marked this pull request as ready for review April 7, 2023 15:05
@shawaj shawaj requested a review from a team as a code owner April 7, 2023 15:05
@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@shawaj shawaj merged commit 00b1272 into master Apr 8, 2023
@shawaj shawaj deleted the shawaj/onboarding branch April 8, 2023 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add tests for incorrect i2c bus/ address in multi key setup
2 participants