feat: add multiple potential key slots for miners #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Syncrobit has multiple potential key locations, change to list and parse list if necessary Closes: NebraLtd/helium-syncrobit#2 (comment)
|
Kudos, SonarCloud Quality Gate passed!
|
4 tasks
shawaj
added a commit
that referenced
this pull request
Mar 11, 2023
This is a quick and hacky fix to the issue described here NebraLtd/helium-syncrobit#2 (comment) The idea is to allow a device level environment variable in balenaCloud to override the key location in the assigned variant without needing to define a new variant. This is useful for testing new devices or in instances like this Syncrobit one to provide a quick fix until we have implemented a "proper" fix to this issue. This additionally changes the following: - we hard code the gateway_mfr_rs version in the [test](https://github.com/NebraLtd/hm-pyhelper/blob/master/.github/workflows/publish-to-pypi-test.yml) and [production](https://github.com/NebraLtd/hm-pyhelper/blob/master/.github/workflows/publish-to-pypi.yml) python package build actions, so there is no need to support old versions of gateway-mfr-rs - due to removing the above, there is also no need to keep the KEY_STORAGE_BUS key in the hardware variants as this is not used anywhere else that I'm aware of **(we should double check this in config, diag, miner, packet forwarder and multiplexer containers just to be 100% sure)** - [Used as a fallback in diag](https://github.com/NebraLtd/hm-diag/blob/23c66980f75568a4cecb18c5375a08cd67bff550/hw_diag/utilities/hardware.py#L200) but not required Relates-to: NebraLtd/helium-syncrobit#2 Relates-to: #221 Relates-to: #222
shawaj
added a commit
that referenced
this pull request
Mar 11, 2023
This is a quick and hacky fix to the issue described here NebraLtd/helium-syncrobit#2 (comment) The idea is to allow a device level environment variable `SWARM_KEY_URI_OVERRIDE` in balenaCloud to override the key location in the assigned variant without needing to define a new variant. This is useful for testing new devices or in instances like this Syncrobit one to provide a quick fix until we have implemented a "proper" fix to this issue. This additionally changes the following: - we hard code the gateway_mfr_rs version in the [test](https://github.com/NebraLtd/hm-pyhelper/blob/master/.github/workflows/publish-to-pypi-test.yml) and [production](https://github.com/NebraLtd/hm-pyhelper/blob/master/.github/workflows/publish-to-pypi.yml) python package build actions, so there is no need to support old versions of gateway-mfr-rs - due to removing the above, there is also no need to keep the KEY_STORAGE_BUS key in the hardware variants as this is not used anywhere else that I'm aware of **(we should double check this in config, diag, miner, packet forwarder and multiplexer containers just to be 100% sure)** - [Used as a fallback in diag](https://github.com/NebraLtd/hm-diag/blob/23c66980f75568a4cecb18c5375a08cd67bff550/hw_diag/utilities/hardware.py#L200) but not required Relates-to: NebraLtd/helium-syncrobit#2 Relates-to: #221 Relates-to: #222
shawaj
added a commit
that referenced
this pull request
Mar 13, 2023
This is a quick and hacky fix to the issue described here NebraLtd/helium-syncrobit#2 (comment) The idea is to allow a device level environment variable `SWARM_KEY_URI_OVERRIDE` in balenaCloud to override the key location in the assigned variant without needing to define a new variant. This is useful for testing new devices or in instances like this Syncrobit one to provide a quick fix until we have implemented a "proper" fix to this issue. This additionally changes the following: - we hard code the gateway_mfr_rs version in the [test](https://github.com/NebraLtd/hm-pyhelper/blob/master/.github/workflows/publish-to-pypi-test.yml) and [production](https://github.com/NebraLtd/hm-pyhelper/blob/master/.github/workflows/publish-to-pypi.yml) python package build actions, so there is no need to support old versions of gateway-mfr-rs - due to removing the above, there is also no need to keep the KEY_STORAGE_BUS key in the hardware variants as this is not used anywhere else that I'm aware of **(we should double check this in config, diag, miner, packet forwarder and multiplexer containers just to be 100% sure)** - [Used as a fallback in diag](https://github.com/NebraLtd/hm-diag/blob/23c66980f75568a4cecb18c5375a08cd67bff550/hw_diag/utilities/hardware.py#L200) but not required Relates-to: NebraLtd/helium-syncrobit#2 Relates-to: #221 Relates-to: #222
shawaj
added a commit
that referenced
this pull request
Mar 13, 2023
…227) * feat: allow override of key location and remove old version support This is a quick and hacky fix to the issue described here NebraLtd/helium-syncrobit#2 (comment) The idea is to allow a device level environment variable `SWARM_KEY_URI_OVERRIDE` in balenaCloud to override the key location in the assigned variant without needing to define a new variant. This is useful for testing new devices or in instances like this Syncrobit one to provide a quick fix until we have implemented a "proper" fix to this issue. This additionally changes the following: - we hard code the gateway_mfr_rs version in the [test](https://github.com/NebraLtd/hm-pyhelper/blob/master/.github/workflows/publish-to-pypi-test.yml) and [production](https://github.com/NebraLtd/hm-pyhelper/blob/master/.github/workflows/publish-to-pypi.yml) python package build actions, so there is no need to support old versions of gateway-mfr-rs - due to removing the above, there is also no need to keep the KEY_STORAGE_BUS key in the hardware variants as this is not used anywhere else that I'm aware of **(we should double check this in config, diag, miner, packet forwarder and multiplexer containers just to be 100% sure)** - [Used as a fallback in diag](https://github.com/NebraLtd/hm-diag/blob/23c66980f75568a4cecb18c5375a08cd67bff550/hw_diag/utilities/hardware.py#L200) but not required Relates-to: NebraLtd/helium-syncrobit#2 Relates-to: #221 Relates-to: #222
shawaj
added a commit
that referenced
this pull request
Mar 14, 2023
Syncrobit has multiple potential key locations, change to list and parse list if necessary Closes: NebraLtd/helium-syncrobit#2 (comment) Supersedes: #222
4 tasks
shawaj
added a commit
that referenced
this pull request
Mar 15, 2023
Syncrobit has multiple potential key locations, change to list and parse list if necessary Relates-to: #221 Relates-to: NebraLtd/helium-syncrobit#2 (comment) Supersedes: #222
shawaj
added a commit
that referenced
this pull request
Mar 15, 2023
Syncrobit has multiple potential key locations, change to list and parse list if necessary Relates-to: #221 Relates-to: NebraLtd/helium-syncrobit#2 (comment) Supersedes: #222
This was referenced Mar 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Syncrobit has multiple potential key locations, change to list and parse list if necessary
Closes: NebraLtd/helium-syncrobit#2 (comment)
Issue
How
Screenshots
References
Checklist