feat: bump protobuf to 4.21.12 #207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
had to regenerate protos using protoc - however not sure I have done it correctly. @NebraLtd/developers I don't suppose any of you have experience with protobuf / protoc? And would be able to check this |
4 tasks
|
@shawaj Not sure what was the reason for updating protobuff but I don't see any issues. |
|
No real reason @pritamghanghas other than for it to be on latest up to date versions |
- update requirements.txt version - regenerate protos with latest versions
shawaj
force-pushed
the
shawaj/protobufup
branch
from
d355aa5 to
ff010bc
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
|
will merge this without version update, and then update version in #208 |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
How
Screenshots
References
Checklist