Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Light hotspot #190

Merged
merged 18 commits into from
Apr 6, 2023
Merged

Light hotspot #190

merged 18 commits into from
Apr 6, 2023

Conversation

pritamghanghas
Copy link
Contributor

Issue

How

Screenshots

References

Checklist

  • Tests added
  • Cleaned up commit history (rebase!)
  • Documentation added
  • Thought about variable and method names

…ails (#321)

grpc client for communication with gatewayrs
Light miner: Diagnostics page should NOT display blockchain details
feat: Light miner: Diagnostics page should NOT display blockchain det…
* bring back json rpc client so that pyhelper remains compatible
with both miner and gateway client API during transition.
@pritamghanghas pritamghanghas requested a review from a team as a code owner August 30, 2022 11:48
hm_pyhelper/miner_param.py Outdated Show resolved Hide resolved
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 18 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 17 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@MuratUrsavas MuratUrsavas self-assigned this Mar 31, 2023
@MuratUrsavas MuratUrsavas force-pushed the light-hotspot branch 5 times, most recently from dfd2360 to 422b581 Compare April 5, 2023 08:50
@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 11 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@MuratUrsavas MuratUrsavas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :P

@MuratUrsavas MuratUrsavas merged commit eac698c into master Apr 6, 2023
@shawaj shawaj deleted the light-hotspot branch April 6, 2023 23:51
shawaj added a commit that referenced this pull request Apr 24, 2023
Revert accidental change in #190 that is causing NebraLtd/hm-pktfwd#140 and NebraLtd/hm-diag#557
shawaj added a commit that referenced this pull request Apr 24, 2023
* Bump version

* fix: revert accidental change

Revert accidental change in #190 that is causing NebraLtd/hm-pktfwd#140 and NebraLtd/hm-diag#557

Co-authored-by: Aaron Shaw <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants