Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with Elixir v1.15 #115

Conversation

kbredemeier
Copy link
Contributor

Hi there,
I was just trying to use the latest RC in a project with elixir v1.15 and ran into a bit of a problem. Not sure if you intended to make this compatible with elixir 1.15 but apparently I am not the only one trying to do this.

Logger.levels/0 was just introduced in elixir v1.16
@AndrewDryga
Copy link
Member

AndrewDryga commented May 17, 2024

Hey @kbredemeier, we can give it a try but I think we should require at least https://github.com/elixir-lang/elixir/releases/tag/v1.15.1 so that important Logger fixes are already there. Can you please update the version spec to something like ~> 1.16 or ~> 1.15.1? And add it to the CI matrix too.

The issue you linked was about rewriting everything because previously we had a full-blown logger back-end that was copied from some ancient Elixir version, and Elixir 1.15 allowed to finally get rid off it :).

@kbredemeier kbredemeier force-pushed the fix-retrieving-logger-levels-with-elixir-1.15 branch from 0e2f40e to 882da48 Compare May 17, 2024 08:08
@kbredemeier
Copy link
Contributor Author

At least the title was refering to v1.15 😅
Sure thing, changed the version to v1.15.1 and updated the CI matrix.

mix.exs Outdated
@@ -8,7 +8,7 @@ defmodule LoggerJSON.Mixfile do
[
app: :logger_json,
version: @version,
elixir: "~> 1.16",
elixir: "~> 1.15.1",
Copy link
Member

@AndrewDryga AndrewDryga May 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will make it work only on 1.15.X so what we really want is ~> 1.16 or ~> 1.15.1. I will fix it up after the merge so no worries about that.

@AndrewDryga AndrewDryga merged commit 75077a9 into Nebo15:master May 17, 2024
0 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants