Add shared option to NnfSystemStorage #417
Conversation
matthew-richerson
requested review from
ajfloeder,
roehrich-hpe and
bdevcich
|
What's the reason for this change again? |
So that a XFS system storage can have a separate file system for each compute node. |
| } else { | ||
| dst.Spec.ExcludeDisabledRabbits = false | ||
| dst.Spec.Shared = true |
There was a problem hiding this comment.
In alpha2/3, you have this set to false, but true here.
| // per compute node. | ||
| // +kubebuilder:default:=true | ||
| Shared bool `json:"shared"` | ||
|
|
||
| // StorageProfile is an object reference to the storage profile to use |
There was a problem hiding this comment.
Where does the user set this? Gitops?
There was a problem hiding this comment.
Anywhere you can create a NnfSystemStorage resource. kubectl, gitops, etc.
There was a problem hiding this comment.
The NnfSystemStorages have a reserved spot here in the boilerplate: https://github.com/NearNodeFlash/argocd-boilerplate/blob/main/environments/example-env/site-config/lvmlock-systemstorage.yaml#L8
So here, in our local gitops: environments/htx-1/site-config/lvmlock-systemstorage.yaml
There was a problem hiding this comment.
So if you have NnfSystemStorages for some other thing, not the lvmlock even/odd situation, you'd add them to another file in site-config.
The shared option determines whether to create a single allocation per Rabbit that is shared between all the computes on the Rabbit, or one allocation per compute node. Signed-off-by: Matt Richerson <[email protected]>
Signed-off-by: Matt Richerson <[email protected]>
matthew-richerson
force-pushed
the
private_system_storage
branch
from
b684d57 to
f4255e5
Compare
|
rebased on master to resolve conflicts |
The shared option determines whether to create a single allocation per Rabbit that is shared between all the computes on the Rabbit, or one allocation per compute node.