NnfDataMovementManager: Add UpdateStrategy to support parallel rolling updates #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g updates The NNF DMM manages the nnf-dm-worker DaemonSet, which is reponsible for the nnf-dm-worker pods. Adding UpdateStrategy to the NnfDataMovementManagerSpec ensures admins can configure the update strategy for those pods. This allows for a non-sequential update when rolling out new worker pods. Signed-off-by: Blake Devcich <[email protected]>
ajfloeder
approved these changes
Feb 13, 2024
roehrich-hpe
approved these changes
Feb 13, 2024
| @@ -50,6 +51,10 @@ type NnfDataMovementManagerSpec struct { | |||
| // manages the per node data movement operations. | |||
| Template corev1.PodTemplateSpec `json:"template"` | |||
|
|
|||
| // UpdateStrategy defines the UpdateStrategy that is used for the basis of the worker Daemon Set | |||
| // that manages the per node data movement operations. | |||
| UpdateStrategy appsv1.DaemonSetUpdateStrategy `json:"updateStrategy"` | |||
There was a problem hiding this comment.
Does it need to be required? Can it be omitempty?
There was a problem hiding this comment.
Never mind, I see that sos has it covered always.
There was a problem hiding this comment.
I originally had it as optional but then changed my mind to just make it a requirement. We basically never want it to use the default of 1 anyway, so I think expecting this field is the way to go.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The NNF DMM manages the nnf-dm-worker DaemonSet, which is reponsible for
the nnf-dm-worker pods. Adding UpdateStrategy to the
NnfDataMovementManagerSpec ensures admins can configure the update
strategy for those pods.
This allows for a non-sequential update when rolling out new worker
pods.
Signed-off-by: Blake Devcich [email protected]