Skip to content

Commit

Permalink
Merge pull request #233 from NearNodeFlash/minimum-mgt
Browse files Browse the repository at this point in the history
Use 5GiB as the default size for an MGT
  • Loading branch information
matthew-richerson authored Oct 16, 2023
2 parents dab0c0d + a54016c commit 268ace7
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion api/v1alpha1/nnfstorageprofile_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ type NnfStorageProfileLustreData struct {

// CapacityMGT specifies the size of the MGT device.
// +kubebuilder:validation:Pattern:="^\\d+(KiB|KB|MiB|MB|GiB|GB|TiB|TB)$"
// +kubebuilder:default:="1GiB"
// +kubebuilder:default:="5GiB"
CapacityMGT string `json:"capacityMgt,omitempty"`

// CapacityMDT specifies the size of the MDT device. This is also
Expand Down
2 changes: 1 addition & 1 deletion api/v1alpha1/nnfstorageprofile_webhook_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -217,7 +217,7 @@ var _ = Describe("NnfStorageProfile Webhook", func() {

// The defaults are found in the kubebuilder validation
// statements in nnfstorageprofile_types.go.
Expect(newProfile.Data.LustreStorage.CapacityMGT).To(Equal("1GiB"))
Expect(newProfile.Data.LustreStorage.CapacityMGT).To(Equal("5GiB"))
Expect(newProfile.Data.LustreStorage.CapacityMDT).To(Equal("5GiB"))
})

Expand Down
2 changes: 1 addition & 1 deletion config/crd/bases/nnf.cray.hpe.com_nnfstorageprofiles.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ spec:
pattern: ^\d+(KiB|KB|MiB|MB|GiB|GB|TiB|TB)$
type: string
capacityMgt:
default: 1GiB
default: 5GiB
description: CapacityMGT specifies the size of the MGT device.
pattern: ^\d+(KiB|KB|MiB|MB|GiB|GB|TiB|TB)$
type: string
Expand Down

0 comments on commit 268ace7

Please sign in to comment.