Add installer for libnnfdm library #59
Conversation
Signed-off-by: Marty McFadden <[email protected]>
| install(TARGETS mylib | ||
| LIBRARY DESTINATION ${CMAKE_INSTALL_LIBDIR} | ||
| PUBLIC_HEADER DESTINATION ${CMAKE_INSTALL_INCLUDEDIR}) | ||
| # Generate install of when running 'make install': |
There was a problem hiding this comment.
This comment is missing something.
Generate install of <what?> when running make install:
There was a problem hiding this comment.
Ah, good question. I probably should have left this comment out. But the subsequent 'install' cmake directories will be used by cmake to generate the install make target so that running "make install" will yield the following files. The piece I wanted to capture was to depict where the installation would go and what the layout would be.
Perhaps I should just remove the entire comment since it may all be derived by the four install directives below?
There was a problem hiding this comment.
I'd prefer you leave the comment section in, maybe remove the word of?
Generate install when running 'make install':
| # | ||
| # Compile with position independant code if we are set to run as a shared library | ||
| # | ||
| set_target_properties(nnfdm PROPERTIES POSITION_INDEPENDANT_CODE ${BUILD_SHARED_LIBS}) |
There was a problem hiding this comment.
should this be POSITION_INDEPENDENT_CODE ?
There was a problem hiding this comment.
Nice catch! This was left in by mistake (by me). I'll take it it out.
Also, address comment feedback from PR review comments. Signed-off-by: Marty McFadden <[email protected]>
Added cmake bits to allow for creation and installation of the following to a specified "install" directory:
install/include/nnfdm/client.h
install/lib/libnnfdm.a
install/share/cmake/nnfdm/nnfdm-targets.cmake
install/share/cmake/nnfdm/nnfdm-targets-release.cmake
install/share/cmake/nnfdm/nnfdm-config.cmake